Version range sets #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames `VersionReq` to `VersionSet`; make a new `VersionReq` that is composed of a set of `VersionSet`'s.
|
This looks great, thanks! |
Merged
|
@steveklabnik: Totally understand! Want to start a discussion in that PR or this one about how to get these changes into a shape that they can be merged? How would you feel about bundling this up with some other improvements and calling it a major version bump? |
|
So, the big thing is that I'd like to move all parsing to nom. I've done that with Version, the question is how to do that with VersionReq. At the moment, I'm trying to debug #54 , and why it also caused failures, but I'd like to do that and re-build this functionality on top of it, if that makes sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of PR #57 (tracked in PR #58).
VersionReqtoVersionSet.VersionReqthat is composed of a set ofVersionSet's.VersionReqstruct.