Use i32::MAX instead of i32::max_value() #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aaah. This library tries to stay compatible back before 1.43? Well, maybe we can tag the example in some way so it passes anyway. The vast majority of users will use a new enough compiler and showing them the best version of the code would be best IMO. |
dtolnay
approved these changes
Nov 20, 2020
dtolnay
added a commit
that referenced
this pull request
Nov 20, 2020
|
Oh. I was just working on adding: //! # use std::i32; // Just for compatibility with Rust < 1.43to the example. But if you are fine anyway then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny change. But just using the newer, simpler and nicer constants.