Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mempool_packages functional test spuriously failed #484

Closed
scravy opened this issue Jan 25, 2019 · 0 comments · Fixed by #690
Closed

mempool_packages functional test spuriously failed #484

scravy opened this issue Jan 25, 2019 · 0 comments · Fixed by #690
Assignees
@cmihai @dsaveliev
Labels
floating test A test that sometimes but not always fails
Milestone
0.1

Comments

@scravy
Copy link
Member

scravy commented Jan 25, 2019

See attached log. It failed in a pull request with absolutely nothing related ( #481 ) in one build only.

mempool_packages_fail.txt
@scravy scravy added the floating test A test that sometimes but not always fails label Jan 25, 2019
@thothd thothd added this to the 0.1 milestone Jan 25, 2019
@dsaveliev dsaveliev mentioned this issue Feb 28, 2019
Merged
scravy added a commit that referenced this issue Feb 28, 2019
@scravy
Merge pull request #690 from dsaveliev/fix-node-stop-rpc-call
6753dac 
Ignore disconnects when stopping node - fixes #367
This is a port of bitcoin/bitcoin#14670

This problem is related to the "stop" RPC call.
It turns out that sometimes the node stops before it sends the response.
That causes the client to retry the call and lead to "ConnectionRefusedError".

I found out that there is a fix in bitcoin repo (in master branch, actually), related to this bug.
In the nutshell, this changes removes forced exit of libevent loop, which allows
to process all the requests gracefully.

Test feature_shutdown.py wasn't ported because it introduces a bug bitcoin/bitcoin#14670 (comment)
The "improvement" bitcoin/bitcoin#14958 requires RPC method "getrpcinfo" which isn't ported from the bitcoin codebase yet.

There are other floating tests with a similar error (ConnectionRefusedError):
fixes #373
fixes #484
fixes #544

Signed-off-by: Dmitry Saveliev <dima@thirdhash.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmihai cmihai

@dsaveliev dsaveliev

Labels
floating test A test that sometimes but not always fails
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Ignore disconnects when stopping node dsaveliev/unit-e-private
4 participants
@cmihai @scravy @dsaveliev @thothd