Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripted-diff: Update year in copyright headers #1072

Merged
merged 1 commit into from
May 8, 2019

Conversation

cornelius
Copy link
Member

@cornelius cornelius commented May 6, 2019

Scripted diff to update copyright years. Extracted from #1069. Needs to be rebased and merged after that pull request.

@pep8speaks
Copy link

pep8speaks commented May 6, 2019

Hello @cornelius! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-07 14:04:47 UTC

@cornelius cornelius added the documentation Documentation label May 6, 2019
@scravy
Copy link
Member

scravy commented May 7, 2019

Nit: The description carries the default template still

-BEGIN VERIFY SCRIPT-
contrib/devtools/copyright_header.py update .
-END VERIFY SCRIPT-

Signed-off-by: Cornelius Schumacher <cornelius@thirdhash.com>
@cornelius cornelius changed the title Update copyright year scripted-diff: Update year in copyright headers May 7, 2019
Copy link
Member

@cmihai cmihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ec4cca

Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8ec4cca

@scravy
Copy link
Member

scravy commented May 8, 2019

As this is the first scripted diff we actively create, I confirm I see it being run and verified in travis:

Screenshot 2019-05-08 11 50 14

ACK 8ec4cca

@cornelius cornelius merged commit a52d88e into dtr-org:master May 8, 2019
@cornelius cornelius deleted the update-copyright-year branch May 8, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants