extract script from .travis.yml + generally improve readability #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyantyn
reviewed
Aug 6, 2018
| - $HOME/.ccache | ||
| - depends/built | ||
| - depends/sdk-sources | ||
| - $HOME/.ccache |
kostyantyn
reviewed
Aug 6, 2018
.travis/lint_06_script.sh
Outdated
| @@ -0,0 +1,10 @@ | |||
|
|
|||
|
|
|||
| ./contrib/devtools/git-subtree-check.sh src/crypto/ctaes | |||
There was a problem hiding this comment.
out of curiosity, is there a reason to start each *.sh file with two blank lines?
There was a problem hiding this comment.
@kostyantyn errrm no not really. I wanted to insert the shebang and copyright headers there :-X
...let me quickly add these...
scravy
force-pushed
the
unit-e-0.16.2+unlock-wallet
branch
from
dc81c96
to
270ce18
Compare
scravy
added
ci
scravy
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same changes as I proposed on bitcoin-core (most of them are merged):
.travis/subject to shellcheck bitcoin/bitcoin#13863