Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segwit remote staking #402

Merged
merged 16 commits into from
Jan 15, 2019
Merged

Segwit remote staking #402

merged 16 commits into from
Jan 15, 2019

Conversation

Nizametdinov
Copy link
Member

@Nizametdinov Nizametdinov commented Dec 20, 2018 •
edited
Loading

This PR implements UIP-15. The implementation includes witness program v1 parsing and signing.

@Nizametdinov Nizametdinov added wip Work in progress which is not supposed to be merged yet consensus wallet and removed wip Work in progress which is not supposed to be merged yet wallet labels Dec 20, 2018
@Nizametdinov Nizametdinov requested a review from a team December 21, 2018 16:16
@mergeable
Copy link

mergeable bot commented Dec 31, 2018

There has not been any activity in the past 10 days. Is this still active?

Ruteri
Ruteri reviewed Jan 2, 2019
View reviewed changes
src/hash.h Show resolved Hide resolved
src/script/interpreter.cpp Outdated Show resolved Hide resolved
src/script/interpreter.cpp Outdated Show resolved Hide resolved
src/script/script.cpp Outdated Show resolved Hide resolved
src/script/standard.cpp Outdated Show resolved Hide resolved
src/script/standard.cpp Show resolved Hide resolved
@Nizametdinov Nizametdinov requested a review from a team January 4, 2019 16:22
@scravy scravy mentioned this pull request Jan 8, 2019
Closed
@Nizametdinov Nizametdinov mentioned this pull request Jan 10, 2019
Closed
@thothd thothd requested a review from scravy January 11, 2019 13:26
@Nizametdinov Nizametdinov requested a review from a team January 15, 2019 09:14
scravy
scravy reviewed Jan 15, 2019
View reviewed changes
src/hash.h Outdated Show resolved Hide resolved
src/hash.h Show resolved Hide resolved
src/pubkey.h Show resolved Hide resolved
test/functional/feature_segwit.py Outdated Show resolved Hide resolved
@Nizametdinov
Refactor witness programs
aa6ae53 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Allow SegWit scripts with several data pushes
f5a652e 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Remote staking witness program
cc5cc52 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Add witness v2 programs to Solver
badbb64 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Fix script tests
6571e90 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Signatures for remote staking scripts
db0e2bd 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Fix base58 test
ca52506 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Remove TODO
8cd043e 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Improve remote-staking transaction test
d598adb 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Fix segwit functional test
1eb1fc4 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Sign P2PKSHA256 script
137441f 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Simplify WitnessProgram
99d4c6d 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Address review comments
2595649 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Clarify in comments witness program size limits
58fcdb9 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
Clarify in comments the difference between SHA-256 and 256-bit hash
f77ba05 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
@Nizametdinov
non-v0 -> unknown version
acec75e 
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
scravy
scravy approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@scravy scravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me!

utACK acec75e

Ruteri
Ruteri reviewed Jan 15, 2019
View reviewed changes
Copy link
Member

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK acec75e

@Ruteri Ruteri requested a review from Gnappuraz January 15, 2019 14:39
@Nizametdinov Nizametdinov merged commit 8fc51a8 into dtr-org:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castarco castarco castarco left review comments

@kostyantyn kostyantyn kostyantyn left review comments

@AM5800 AM5800 AM5800 left review comments

@Ruteri Ruteri Ruteri left review comments

@scravy scravy scravy approved these changes

@Gnappuraz Gnappuraz Awaiting requested review from Gnappuraz

Assignees
No one assigned
Labels
consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nizametdinov @castarco @scravy @kostyantyn @AM5800 @Ruteri