Handle archives with duplicate files #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test file is taken from: ```bash ❯ wget https://download-ib01.fedoraproject.org/pub/epel/7/x86_64/Packages/b/bdsync-0.11.2-1.el7.x86_64.rpm ```
Archives with multiple instances of the same file (generally not found in the wild, but some .jar builders seem to produce them 🤷) will hang indefinitely waiting on a hidden 7z prompt. Instead, float an error or overwrite depending on flags. Fixes #29.
noahp
force-pushed
the
noahp/rpm
branch
2 times, most recently
from
5da9295
to
45dfee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archives with multiple instances of the same file (generally not found
in the wild, but some .jar builders seem to produce them 🤷)
will hang indefinitely waiting on a hidden 7z prompt. Instead, float an
error or overwrite depending on flags.
Fixes #29.