Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google OAuth OOB, add loopback server #26

Merged
merged 5 commits into from
Oct 8, 2022

Conversation

carsonreinke
Copy link
Contributor

@carsonreinke carsonreinke commented Sep 2, 2022

Fixes #25.

Adds a loopback server that spins up when starting the authentication process so the auth code can be pulled directly from the callback.

https://developers.google.com/identity/protocols/oauth2/resources/oob-migration
https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html

@carsonreinke carsonreinke marked this pull request as ready for review September 3, 2022 01:11
@carsonreinke carsonreinke changed the title Remove Google OAuth OOB by having user copy/paste code Remove Google OAuth OOB, add loopback server Sep 3, 2022
carsonreinke added a commit to carsonreinke/reinke.co that referenced this pull request Sep 3, 2022
@carsonreinke
Copy link
Contributor Author

@dtylman any chance you can take a look at this?

Copy link
Collaborator

@SijmenHuizenga SijmenHuizenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this pr! Just tested this and it works exactly as described in the docs, lovely.

@SijmenHuizenga SijmenHuizenga merged commit 9be5560 into dtylman:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth out-of-band (OOB) flow will be deprecated on October 3, 2022
2 participants