Performance issue, It could work x3 times better!

[nikolay-zakharov]

Hi, I've found a performance bottleneck:

Script version: 1.6.1
Problems are found at lines: 105-107 and 109-111

Original code (lines 105-107):

    $this
        .datepicker("option", "minDate", min_date)
        .datepicker("option", "maxDate", max_date);

Original code (lines 109-111):

    $this
        .datepicker("option", "minDate", this.multiDatesPicker.minDate)
        .datepicker("option", "maxDate", this.multiDatesPicker.maxDate);

This is a bad thing. Each call of $this.datepicker('option', 'min/maxDate', ...) makes datepicker and multiDatesPicker to execute onBeforeShow event listeners for each of the days you have visible in your calendar. So in my 1-year calendar (12*35 days ~ 420 days) single attempt to select a day executes onBeforeShow for 3 times for each day! And it takes about 350 ms x 3 times ~ 1.05 sec for stucking. But if you apply my fix (it is available below), you'll be forced to wait 3 times less before you can click another date.

My suggestion is:
It's better to modify those lines to get them this like:

My solution for lines 105-107

    if(methods.compareDates($this.datepicker("option", "minDate"), min_date) !== 0) 
        $this.datepicker("option", "minDate", min_date)
    if(methods.compareDates($this.datepicker("option", "maxDate"), max_date) !== 0) 
        $this.datepicker("option", "maxDate", max_date)

My solution for lines 109-111

    if(methods.compareDates($this.datepicker("option", "minDate"), this.multiDatesPicker.minDate) !== 0)
        $this.datepicker("option", "minDate", this.multiDatesPicker.minDate);
    if(methods.compareDates($this.datepicker("option", "maxDate"), this.multiDatesPicker.maxDate) !== 0)
        $this.datepicker("option", "maxDate", this.multiDatesPicker.maxDate);

It improves performance of onSelect event for 3 times with the same functionality.

Thanks for this great plugin!

[minitech]

You should probably submit a pull request...

[ghost]

Pull request merged, thanks for the help.