-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures in engine while trying to run Environment #560
Comments
Indeed there is an issue. I think it comes from the contact model that is based by default on collision geometries instead of frames. The former is supposed to be more realistic but untested for now and numerically unstable model. I'm going to rework internally this part of the engine in a near future to handle generic collisions (collisions of all bodies with the ground plus auto-collisions). For now, here is a PR fixing your issue ! Basically it is sufficient to overwrite the default options, so there is no need to fix jiminy itself. But it you want, I could make a new release of Jiminy that includes these changes. By the way, I would advice you to use the environment with low-level PID controllers: |
I see you did some work based on jiminy here. If you have any question or want me to give you some advice / code review, do not hesitate. The documentation of jiminy is quite poor and providing a comprehensive tutorial would be amazing ! |
Thanks! |
So, in the end do you need me to release a new version fixing the issue or you are planning to overwrite the base configuration manually? |
I overwrote the base configuration in my downloaded version of the package, so no worries! |
Perfect ! |
Hello,
Would it be okay if you could give us a brief explanation as what do they mean? I know they are upper and lower limits, but why separately to Q and V? Sorry for asking as I am not familiar with PID controls. Thank you so much for your help in advance! |
There is one PID controller per motor. Each of them are responsible for the sending actual torque based on the error between the current and target state for the motors. More details are available here. In this case, the action is no longer the torque directly, but the target state of each motor. These low-level PID controllers are supposed to update the current torque at a higher rate than the action. More information about why doing this is important can be found in the sub-section about the action space of my preprint available on arxiv. For simplicity, I advice you to only ignore completely the target velocity and set it to zero systematically, so that the policy only output the desired position of the motors and not the combination of both position and velocity. |
Thank you very much for your swiftly response! I will give that a try.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Alexis DUBURCQ ***@***.***>
Sent: Friday, August 19, 2022 2:02:14 PM
To: duburcqa/jiminy ***@***.***>
Cc: SDJoeKing ***@***.***>; Comment ***@***.***>
Subject: Re: [duburcqa/jiminy] Failures in engine while trying to run Environment (Issue #560)
There is one PID controller per motor. Each of them are responsible for the sending actual torque based on the error between the current and target state for the motors. More details are available here<https://en.wikipedia.org/wiki/PID_controller>. In this case, the action is no longer the torque directly, but the target state of each motor. These low-level PID controllers are supposed to update the current torque at a higher rate than the action. More information about why doing this is important can be found in the sub-section about the action space of my preprint available on arxiv<https://arxiv.org/pdf/2203.01148.pdf>.
For simplicity, I advice you to only ignore completely the target velocity and set it to zero systematically, so that the policy only output the desired position of the motors and not the combination of both position and velocity.
—
Reply to this email directly, view it on GitHub<#560 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQPEGDQXNAK5T6V2JKLYTKTVZ6AVNANCNFSM562QNMEQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
No problem ! Feel free to ask if you need more details or you have any additional question :) |
Hi,
I'm trying to train an agent to run the Anymal Environment in jupyter notebook with python 3.8.10.
I'm getting this error in the notebook:
And I'm getting this error printed to the terminal:
Simple code to reproduce (you may have to run a few times)
The text was updated successfully, but these errors were encountered: