Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/simulator] First-class multi-robot support. #754

Merged
merged 15 commits into from
Apr 12, 2024

Conversation

20chupin
Copy link
Contributor

@20chupin 20chupin commented Apr 8, 2024

Related to #246

Adapt render to multi robots simulations

Adapt log reading to multi robots

Cleans the test and corrects multi robots log with empty name

Add colors in render and callback

COLORS

Build is not robot-specific anymore
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
core/src/engine/engine.cc Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/robot.py Outdated Show resolved Hide resolved
python/jiminy_py/unit_py/test_simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/log.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
python/jiminy_py/src/jiminy_py/simulator.py Outdated Show resolved Hide resolved
@duburcqa duburcqa marked this pull request as ready for review April 10, 2024 15:37
@duburcqa
Copy link
Owner

Looks like it is ready to merge now ;)

@duburcqa
Copy link
Owner

Good job !

@duburcqa duburcqa enabled auto-merge (squash) April 10, 2024 15:38
@duburcqa
Copy link
Owner

Just make sure that all tests pass.

@duburcqa duburcqa changed the title Add multi-robots to Simulator [python/simulator] First-class multi-robot support. Apr 11, 2024
@duburcqa duburcqa disabled auto-merge April 11, 2024 11:44
@duburcqa duburcqa enabled auto-merge (squash) April 11, 2024 11:44
duburcqa
duburcqa previously approved these changes Apr 11, 2024
auto-merge was automatically disabled April 11, 2024 12:07

Head branch was pushed to by a user without write access

@duburcqa duburcqa merged commit ddbab08 into duburcqa:dev Apr 12, 2024
26 of 31 checks passed
@duburcqa duburcqa mentioned this pull request Apr 19, 2024
duburcqa added a commit that referenced this pull request Apr 19, 2024
* [core] Fix bias/noise check for EncoderSensor. (#744)
* [core] Fix some symbols not exported by mistake. (#742)
* [core] Catch exception during stepper integration. (#747)
* [core] Clarify terminology: 'Rigid' by 'Mechanical', 'Original' by 'Theoretical', 'Actual' by 'Extended'. (#753) (#762) (#763)
* [core] More appropriate tolerance when checking GCD to avoid false positive. (#753)
* [core] User is now systematically responsible for serializing constants before telemetry registration. (#753)
* [core] Various cleanup and minor improvements. (#753)
* [core] Add 'JIMINY' namespace to macros. (#755)
* [core] Add methods to get / set all simulation options at once. (#760) 
* [core] More robust set/get options logics. (#761)
* [core] Add backlash support at motor-level. (#767)
* [core|python/simulator] Cleanup get/set options for multi-robot simulations. (#758)
* [core/python] Faster 'array_copyto'. (#740)
* [core/python] Do not export bindings. (#742)
* [core/python] Expose more convenience getters. (#748) 
* [core/python] Add method to query heightmaps on multiple positions at once. (#750)
* [python/viewer] Fix arrow maker for negative length with panda3d backend.
* [python/viewer] Fix arrow marker for 'anchor_top=True' with panda3d.
* [python/viewer] Fix viewer automatic closing during repley not working. (#756)
* [python/simulator] First-class multi-robot support. (#754) (#766)
* [python/plot] Add multi-robot support. (#764)
* [gym/common] Fix corrupted robot proxy if model changes. (#746)
* [gym/common] Introduce new first-class quantity manager. (#749) (#751) (#752) (#756)
* [gym/common] Initialize sensor measurements at init. (#750)
* [gym/common] Plot state, action and features of all pipeline blocks. (#750)
* [gym/common] PD controller now satisfies position, velocity and acceleration bounds. (#750) (#765) (#768)
* [gym/common] Allows PD control with position action.  (#750)
* [gym/common] Remove PD target dead band. (#750)
* [gym/common] Decouple PD controller action order adapter from acceleration integration. (#764)
* [gym/common] Refactor 'compute_command' to operate in-place. (#764)
* [gym/rllib] Migrate from ray[rllib]==2.5.0 to 2.9.*. (#739)
* [misc] Fix documentation formating.
* [misc] Add YAPF formatting configuration (opt-in). (#739)
* [misc] More robust build scripts. (#739)
* [misc] Allow failure when installing gym_jiminy add-on modules. (#739)
* [misc] Run all unit tests for gym jiminy base modules on Python 3.12 and Debug. (#739)
* [misc] Support Numpy 2.0.0b1. (#740)
* [misc] Upgrade C++ dependencies. (#741) 
* [misc] Fix compilation on Windows ARM64. (#746)
* [misc] Fix numpy version requirement. (#750)
* [misc] Update documentation. (#750)

---------

Co-authored-by: Alexis Duburcq <alexis.duburcq@wandercraft.eu>
Co-authored-by: Grégoire Roussel <gregoire.roussel@wandercraft.eu>
Co-authored-by: Amandine <amandine.chupin@wandercraft.health>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants