Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ More efficient shrinker on double #1384

Merged
merged 2 commits into from Jan 21, 2021
Merged

⚡️ More efficient shrinker on double #1384

merged 2 commits into from Jan 21, 2021

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 20, 2021

In a nutshell

❌ New feature
❌ Fix an issue
❌ Documentation improvement
✔️ Other: shrinker quality/speed

(✔️: yes, ❌: no)

Potential impacts

Shrinker of double and arrayInt will be impacted

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be118fa:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #1384 (be118fa) into master (f7672bb) will decrease coverage by 0.27%.
The diff coverage is 79.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   98.55%   98.27%   -0.28%     
==========================================
  Files          91       91              
  Lines        3047     3078      +31     
  Branches      586      600      +14     
==========================================
+ Hits         3003     3025      +22     
- Misses         41       50       +9     
  Partials        3        3              
Flag Coverage Δ
e2e-tests 89.08% <76.74%> (-0.03%) ⬇️
e2e-tests-10.x-Linux 89.01% <76.74%> (-0.02%) ⬇️
e2e-tests-10.x-Windows 87.13% <76.74%> (+0.03%) ⬆️
e2e-tests-10.x-macOS 89.08% <76.74%> (-0.03%) ⬇️
e2e-tests-12.x-Linux 89.05% <76.74%> (-0.02%) ⬇️
e2e-tests-12.x-Windows 87.10% <76.74%> (+0.03%) ⬆️
e2e-tests-12.x-macOS 89.08% <76.74%> (+0.01%) ⬆️
e2e-tests-14.x-Linux 89.05% <76.74%> (-0.02%) ⬇️
e2e-tests-14.x-Windows 87.10% <76.74%> (-0.04%) ⬇️
e2e-tests-14.x-macOS 89.05% <76.74%> (-0.02%) ⬇️
unit-tests 96.42% <51.16%> (-0.66%) ⬇️
unit-tests-10.x-Linux 96.39% <51.16%> (-0.66%) ⬇️
unit-tests-12.x-Linux 96.42% <51.16%> (-0.66%) ⬇️
unit-tests-14.x-Linux 96.42% <51.16%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/check/arbitrary/helpers/ArrayInt64Arbitrary.ts 89.41% <79.06%> (-10.59%) ⬇️
src/check/arbitrary/MixedCaseArbitrary.ts 98.24% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7672bb...be118fa. Read the comment docs.

@github-actions
Copy link
Contributor

Give a try to cecf436 with:

yarn add https://6008af0cc87c2a1934f3f8b1--dazzling-goodall-4f0e38.netlify.app/fast-check.tgz
npm i https://6008af0cc87c2a1934f3f8b1--dazzling-goodall-4f0e38.netlify.app/fast-check.tgz

Or have a look to the generated documentation.

@dubzzz dubzzz changed the title ⚡️ More efficient shrinker on arrayInt64 ⚡️ More efficient shrinker on double Jan 21, 2021
@github-actions
Copy link
Contributor

Give a try to be118fa with:

yarn add https://6009d8d724b5242cd89e7125--dazzling-goodall-4f0e38.netlify.app/fast-check.tgz
npm i https://6009d8d724b5242cd89e7125--dazzling-goodall-4f0e38.netlify.app/fast-check.tgz

Or have a look to the generated documentation.

@dubzzz dubzzz merged commit a0a6445 into master Jan 21, 2021
@dubzzz dubzzz deleted the faster-double branch January 21, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant