👷 Attempt to switch to pnp linker #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target being a faster CI!
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce97804:
|
dubzzz
commented
Oct 23, 2023
12 tasks
dubzzz
added a commit
that referenced
this pull request
Oct 24, 2023
Up-to-now we have been importing buffer while it's a known native package in node. So in order to avoid node from pulling its own, we were relying on path import. We switched to a way safer approach: we alias the buffer package with another name and we import it via its other name. It avoid path related hazards and let the package manager and node responsible to tell the code where to find the relevant package. Satellite PR for #4368
12 tasks
dubzzz
added a commit
that referenced
this pull request
Oct 24, 2023
Up-to-now when changing the test runner used internally by Jest, we were passing it the full path to the runner and its entry point. This approach proved fragile when we attempted to switch to Yarn in PnP mode. This PR change the way we declare the runner: we stop passing the path to the entry point and just pass its name. Satellite PR for #4368
12 tasks
Codecov Report
@@ Coverage Diff @@
## main #4368 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 207 207
Lines 5013 5013
Branches 1368 1368
=======================================
Hits 4691 4691
Misses 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. |
dubzzz
added a commit
that referenced
this pull request
Oct 24, 2023
Up-to-now when changing the test runner used internally by Jest, we were passing it the full path to the runner and its entry point. This approach proved fragile when we attempted to switch to Yarn in PnP mode. This PR change the way we declare the runner: we stop passing the path to the entry point and just pass its name. Satellite PR for #4368
dubzzz
added a commit
that referenced
this pull request
Oct 24, 2023
Up-to-now we have been importing buffer while it's a known native package in node. So in order to avoid node from pulling its own, we were relying on path import. We switched to a way safer approach: we alias the buffer package with another name and we import it via its other name. It avoid path related hazards and let the package manager and node responsible to tell the code where to find the relevant package. Satellite PR for #4368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target being a faster CI!
Category:
Potential impacts: