Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘· Attempt to switch to pnp linker #4368

Merged
merged 26 commits into from Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 10 additions & 9 deletions .github/workflows/build-status.yml
Expand Up @@ -36,9 +36,6 @@ jobs:
check-latest: true
- name: Update Yarn cache
if: steps.yarn-cache.outputs.cache-hit != 'true'
env:
# Using PNP linker for better performance
YARN_NODE_LINKER: pnp
run: yarn install --immutable --mode=skip-build --check-cache
warmup_yarn_cache_others:
name: 'Warm up Yarn cache (others)'
Expand All @@ -58,9 +55,6 @@ jobs:
check-latest: true
- name: Update Yarn cache
if: steps.yarn-cache.outputs.cache-hit != 'true'
env:
# Using PNP linker for better performance
YARN_NODE_LINKER: pnp
run: yarn install --immutable --mode=skip-build --check-cache

# Jobs without any strong requirement on warmup_yarn_cache
Expand Down Expand Up @@ -317,7 +311,11 @@ jobs:
- name: Generate documentation
run: yarn workspace website build
- name: Generate API reference
run: yarn workspace fast-check docs-ci
env:
YARN_NODE_LINKER: 'node-modules'
run: |
yarn install --immutable --immutable-cache --mode=skip-build
yarn workspace fast-check docs-ci
- name: Copy API reference within documentation
run: mv packages/fast-check/docs website/build/api-reference
- name: Upload documentation
Expand Down Expand Up @@ -352,10 +350,15 @@ jobs:
run: yarn workspaces foreach -pvi --no-private exec yarn node $(yarn bin packaged) --keep-node-modules
- name: Retrieve potentially dropped test-bundle
run: yarn workspaces foreach -pvi --no-private exec "git restore -s@ -SW -- test-bundle || true"
- name: Check publication lint
run: yarn publint:all
- name: Check bundles
run: yarn workspaces foreach -pvi --no-private run test-bundle
- name: Check legacy bundles
env:
YARN_NODE_LINKER: 'node-modules'
run: |
yarn install --immutable --immutable-cache --mode=skip-build
export NODE_VERSION="$(node --version)"
export NVS_HOME="$HOME/.nvs"
git clone --branch v1.7.1 --depth 1 https://github.com/jasongin/nvs "$NVS_HOME"
Expand All @@ -374,8 +377,6 @@ jobs:
echo "ERROR: Node version got updated from $NODE_VERSION to $(node --version)"
exit 3
fi
- name: Check publication lint
run: yarn publint:all
test_types:
name: 'Test types'
needs:
Expand Down
6 changes: 6 additions & 0 deletions .yarn/versions/ffaf8392.yml
@@ -0,0 +1,6 @@
declined:
- fast-check
- "@fast-check/jest"
- "@fast-check/poisoning"
- "@fast-check/vitest"
- "@fast-check/worker"
2 changes: 1 addition & 1 deletion .yarnrc.yml
@@ -1,6 +1,6 @@
enableGlobalCache: true
enableScripts: false
nodeLinker: node-modules
nodeLinker: pnp

plugins:
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -32,7 +32,8 @@
"eslint": "^8.52.0",
"eslint-config-prettier": "^9.0.0",
"prettier": "3.0.3",
"publint": "^0.2.5"
"publint": "^0.2.5",
"typescript": "~5.2.2"
},
"resolutions": {
"react@^17.0.2": "patch:react@npm%3A17.0.2#./.yarn/patches/react-npm-17.0.2-99ba37d931.patch"
Expand Down
2 changes: 1 addition & 1 deletion packages/fast-check/test/e2e/NoRegressionStack.spec.ts
Expand Up @@ -44,7 +44,7 @@ function sanitize(run: () => void) {
.replace(/\\/g, '/')
.replace(/at [^(]*fast-check\/(packages|node_modules)(.*)/g, 'at $1$2')
.replace(/at (.*) \(.*fast-check\/(packages|node_modules)(.*)\)/g, 'at $1 ($2$3)')
.replace(/at (.*) \((node_modules\/.*):\d+:\d+\)/g, 'at $1 ($2:?:?)') // reducing risks of changes on bumps
.replace(/at (.*) \(.*\/(\.yarn|Yarn)\/.*\/(node_modules\/.*):\d+:\d+\)/g, 'at $1 ($3:?:?)') // reducing risks of changes on bumps: .yarn (Linux and Mac), Yarn (Windows)
.split('\n');
throw new Error(
lines
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
Expand Up @@ -2808,6 +2808,7 @@ __metadata:
eslint-config-prettier: ^9.0.0
prettier: 3.0.3
publint: ^0.2.5
typescript: ~5.2.2
languageName: unknown
linkType: soft

Expand Down