Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix console errors of website #4712

Merged
merged 1 commit into from Feb 17, 2024
Merged

🚨 Fix console errors of website #4712

merged 1 commit into from Feb 17, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 17, 2024

Category:

  • ✨ Introduce new features
  • πŸ“ Add or update documentation
  • βœ… Add or update tests
  • πŸ› Fix a bug
  • 🏷️ Add or update types
  • ⚑️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

@dubzzz dubzzz enabled auto-merge (squash) February 17, 2024 14:49
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f76bec:

Sandbox Source
@fast-check/examples Configuration

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (3e56c4f) 93.57% compared to head (1f76bec) 93.57%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4712   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files         207      207           
  Lines        5011     5011           
  Branches     1367     1367           
=======================================
  Hits         4689     4689           
  Misses        322      322           
Flag Coverage Ξ”
unit-tests 93.57% <ΓΈ> (ΓΈ)
unit-tests-18.x-Linux 93.57% <ΓΈ> (ΓΈ)
unit-tests-20.x-Linux 93.57% <ΓΈ> (+0.01%) ⬆️
unit-tests-latest-Linux 93.57% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 0ec5701 into main Feb 17, 2024
52 checks passed
@dubzzz dubzzz deleted the fix-console-error branch February 17, 2024 14:57
dubzzz added a commit that referenced this pull request Feb 18, 2024
Before the fix #4712, the Call To Action (aka CTA) for "Quick Start - 5min" used to be after a 1.25rem spacing (20px).

The fix, dropped that spacing putting the CTA button to close from its preceding title. We just put back (part of) this spacing.
dubzzz added a commit that referenced this pull request Feb 18, 2024
Before the fix #4712, the Call To Action (aka CTA) for "Quick Start - 5min" used to be after a 1.25rem spacing (20px).

The fix, dropped that spacing putting the CTA button to close from its preceding title. We just put back (part of) this spacing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant