Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ Add extra spacing on top of CTA #4713

Merged
merged 1 commit into from Feb 18, 2024
Merged

πŸ’„ Add extra spacing on top of CTA #4713

merged 1 commit into from Feb 18, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 18, 2024

Before the fix #4712, the Call To Action (aka CTA) for "Quick Start - 5min" used to be after a 1.25rem spacing (20px).

The fix, dropped that spacing putting the CTA button to close from its preceding title. We just put back (part of) this spacing.

Category:

  • ✨ Introduce new features
  • πŸ“ Add or update documentation
  • βœ… Add or update tests
  • πŸ› Fix a bug
  • 🏷️ Add or update types
  • ⚑️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Before the fix #4712, the Call To Action (aka CTA) for "Quick Start - 5min" used to be after a 1.25rem spacing (20px).

The fix, dropped that spacing putting the CTA button to close from its preceding title. We just put back (part of) this spacing.
@dubzzz dubzzz enabled auto-merge (squash) February 18, 2024 14:14
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ea25efd:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz merged commit 16b54ea into main Feb 18, 2024
50 checks passed
@dubzzz dubzzz deleted the add-back-spacing branch February 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant