Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature status to version #188

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

sorairolake
Copy link
Contributor

Closes #185

Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that xh --version is outputting more than the version, can you update install.sh script to get the first line only?

-echo "$("$bindir"/xh --version) has been installed to:"
+echo "$("$bindir"/xh --version | head -1) has been installed to:"

Other than that, everything looks good.

@sorairolake
Copy link
Contributor Author

@ducaale Sure.

Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🎉

@ducaale ducaale merged commit 8097b6b into ducaale:develop Nov 8, 2021
@sorairolake sorairolake deleted the improve-version branch November 8, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants