Change to output the feature status only in --version
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducaale
reviewed
Nov 13, 2021
sorairolake
force-pushed
the
long-version
branch
from
63b94af
to
e08e569
Compare
blyxxyz
reviewed
Nov 14, 2021
| @@ -1009,6 +1009,11 @@ fn safe_exit() -> ! { | |||
| std::process::exit(0); | |||
| } | |||
|
|
|||
| #[inline] | |||
There was a problem hiding this comment.
There's no need to add this, "obvious" things are inlined automatically. Compilers really like inlining things.
You only need it if you want something to be inlined across crates, or if you think the compiler will guess wrong.
(It's harmless so there's no hurry to clean it up, and I did the same thing in buffer.rs before I knew this 🙂)
There was a problem hiding this comment.
Oh I see. I will remember to remove the inline attribute here before making a release tonight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the feature status from output of
-Vand--help(same asrg).