Add support for nested json syntax #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducaale
force-pushed
the
nested-json
branch
7 times, most recently
from
5d0b8c1
to
7f7023d
Compare
ducaale
force-pushed
the
nested-json
branch
2 times, most recently
from
a290382
to
2e3d656
Compare
- Numbers can be escaped in order to be treated as string
e.g foo[\5]=hello.
- Data type clashes will lead to a hard error e.g foo[x]=5 foo[]=6
or x=5 x[x]=7.
- The "append by default" behavior has been abandoned e.g x=1 x=2 equals
{"x": "1"} instead of {"x": ["1", "2"]}.
also renames set_value to insert
blyxxyz
reviewed
Jun 5, 2022
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
blyxxyz
approved these changes
Jun 9, 2022
| @@ -6,6 +6,33 @@ use anyhow::Result; | |||
| use reqwest::blocking::Request; | |||
| use url::{Host, Url}; | |||
|
|
|||
| pub fn unescape(text: &str, special_chars: &'static str) -> String { | |||
There was a problem hiding this comment.
It took me a minute to figure out that e.g. --form '\]=a' is why special_chars can have different values. Can you add a test case?
src/nested_json.rs
Outdated
Comment on lines
384
to
390
| // HTTPie currently escapes numbers regardless of whether they are between | ||
| // square brackets or not: | ||
| // | ||
| // $ http --offline --pretty=none --print=B : \\0[\\5]=x | ||
| // {"0":{"5": "x"}} | ||
| // $ xh --offline --pretty=none --print=B : \\0[\\5]=x | ||
| // {"\\0": {"5": "x"}} |
There was a problem hiding this comment.
Now that it's confirmed to be a bug I'd also put a link to the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3