New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init parsing regex for RequestItem only once #22

Merged

ducaale merged 1 commit into ducaale:master from jRimbault:master

Feb 6, 2021

Contributor

jRimbault commented Feb 6, 2021 •

edited

Loading

I thought maybe you might appreciate that. Perhaps also investigate replacing lazy_static with the safer once_cell::sync::Lazy ?

And BTW in Rust 2018 edition you don't need :

#[macro_use]
extern crate name;


          init parsing regex for RequestItem once

f89f3f5

Owner

ducaale commented Feb 6, 2021

Thanks for PR, @jRimbault.

Perhaps also investigate replacing lazy_static with the safer once_cell::sync::Lazy?

I agree. Also, it seems that once_cell will be part of std in the future which is great!

ducaale merged commit 354c934 into ducaale:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet