Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using OS certificate store with rustls #225

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Enable using OS certificate store with rustls #225

merged 1 commit into from
Jan 21, 2022

Conversation

austinbutler
Copy link
Contributor

Closes #224.

I ran cargo update since I didn't know the command to just update the lockfile after changing Cargo.toml, but it worked and created no additional test failures so I've left that. If you want the smaller set of Cargo.lock changes let me know.

Two tests fail, but they also fail for me on master:

  • basic_auth_from_session_is_used
  • bearer_auth_from_session_is_used

Is there any additional setup required for the tests?

@blyxxyz
Copy link
Collaborator

blyxxyz commented Jan 21, 2022

Can you target develop instead of master?

That might get rid of your local test failures too, I think I remember netrc files affecting those tests before #207.

I ran cargo update since I didn't know the command to just update the lockfile after changing Cargo.toml, but it worked and created no additional test failures so I've left that.

The lockfile is automatically updated after a rebuild (e.g. cargo test, cargo check, etc), so you shouldn't have to take any special action.

If you want the smaller set of Cargo.lock changes let me know.

Running cargo update every once in a while is good practice, but in this case it seems to have messed with our minimum version requirement, so could you try the smaller set?

@austinbutler
Copy link
Contributor Author

Can you target develop instead of master?

Done, and that did resolve the test failures. Also removed the cargo update changes.

The lockfile is automatically updated after a rebuild

TIL!

@austinbutler austinbutler changed the base branch from master to develop January 21, 2022 23:04
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ducaale ducaale merged commit 7cb374e into ducaale:develop Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnknownIssuer error with private CA
3 participants