Use custom netrc parser #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us get rid of our most obscure direct dependency. The new parser: - Supports comment syntax (like Python/requests/HTTPie) - Is more faithful to HTTPie in general - Is less strict (maybe a good thing because we don't show errors) - Normalizes hostnames (we could've done this with the old parser) - Should be more efficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our most obscure direct dependency.
The new parser:
It's a fair amount of code to add, but I feel better about having it here instead of hiding it in a crate that nobody else uses and we don't control. I hope you agree.