Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source tags available to plugins through the SourceConfig #228

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

AlexanderVR
Copy link
Contributor

I have a custom plugin where I'd like to use the source's tags to inform the plugin load method. This MR adds the source tags as an additional SourceConfig attribute.

Additionally, when attempting to ensure existing plugin tests passed, ran into the issue that tests that should be skipped when the test profile is not md would still load the motherduck plugin and attempt a connection. This is happening because any test classes using the dbt project fixture will execute it before the skip_by_profile_type fixture, as the former is at the higher class-level scope, thus rendering the pytest.mark.skip_profile decorator ineffectual

Fix: changed skip_by_profile_type autouse fixture from function to class scope.

@AlexanderVR AlexanderVR requested a review from jwills August 8, 2023 07:43
@jwills
Copy link
Collaborator

jwills commented Aug 8, 2023

@AlexanderVR tags stuff LGTM obvi, but I'm puzzled by this MD test failure, does it make sense to you?

@jwills
Copy link
Collaborator

jwills commented Aug 8, 2023

Ack okay looking more closely it looks like a token provided error, which shouldn't actually be an issue, I bet it's some dumb GH thing I haven't configured correctly

@jwills jwills merged commit 8b6f366 into duckdb:master Aug 8, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants