Switch to using DuckDB's built-in date_diff function for the datediff utils macro #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexledesma
added a commit
to dagster-io/dagster
that referenced
this pull request
Feb 22, 2024
## Summary & Motivation This stopped working probably because of duckdb/dbt-duckdb#334. Just edit our usage of the `.get_base_dates`. We still use https://github.com/calogica/dbt-date since `dbt.date_spine` is only available in >1.7. Also, it doesn't really matter how we generate this time spine since we just want a manifest to be created properly. ## How I Tested These Changes bk, tox
rexledesma
added a commit
to dagster-io/dagster
that referenced
this pull request
Feb 22, 2024
## Summary & Motivation This stopped working probably because of duckdb/dbt-duckdb#334. Just edit our usage of the `.get_base_dates`. We still use https://github.com/calogica/dbt-date since `dbt.date_spine` is only available in >1.7. Also, it doesn't really matter how we generate this time spine since we just want a manifest to be created properly. ## How I Tested These Changes bk, tox
PedramNavid
pushed a commit
to dagster-io/dagster
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation This stopped working probably because of duckdb/dbt-duckdb#334. Just edit our usage of the `.get_base_dates`. We still use https://github.com/calogica/dbt-date since `dbt.date_spine` is only available in >1.7. Also, it doesn't really matter how we generate this time spine since we just want a manifest to be created properly. ## How I Tested These Changes bk, tox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some cruft with the 0.10.0 release coming out