Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run MotherDuck integration tests on master, skip for pull requests #378

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

guenp
Copy link
Collaborator

@guenp guenp commented Apr 13, 2024

This PR adds a job that checks if the MotherDuck token is defined, and only runs the integration tests if it is. This way the job is just skipped instead of failing with a Cannot connect to MotherDuck server: no token provided. error.
Additionally, I've updated the push trigger branch name to master so the tests always run after PRs are merged.

For more detailed info see:

https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
https://gist.github.com/GuillaumeFalourd/d3524cf6361afad87b9da3bf78270bc1

@jwills jwills merged commit 36c7013 into duckdb:master Apr 13, 2024
30 of 31 checks passed
@jwills
Copy link
Collaborator

jwills commented Apr 13, 2024

Thank you @guenp !

@guenp guenp deleted the guenp/md-integration-tests-fix branch April 15, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants