query cancellation attempt #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrl20
force-pushed
the
louisa/query-cancellation
branch
2 times, most recently
from
5d7d1d5
to
f0a374b
Compare
hrl20
force-pushed
the
louisa/query-cancellation
branch
from
f0a374b
to
14ce3a2
Compare
jwills
reviewed
Apr 17, 2024
| @@ -51,10 +51,6 @@ class DuckDBAdapter(SQLAdapter): | |||
| def date_function(cls) -> str: | |||
| return "now()" | |||
|
|
|||
| @classmethod | |||
| def is_cancelable(cls) -> bool: | |||
| return False | |||
There was a problem hiding this comment.
Mmm should we make this environment dependent, possibly?
| @@ -58,6 +58,9 @@ def notify_closed(self): | |||
| if self.handle_count == 0 and not self._keep_open: | |||
| self.close() | |||
|
|
|||
| def cancel(cls, connection: Connection): | |||
| connection.handle.cursor().interrupt() | |||
There was a problem hiding this comment.
Is this a new feature of MD or of DuckDB in general?
There was a problem hiding this comment.
This is a duckdb feature: duckdb/duckdb#7895
I also manually tested it with MD and saw the expected behavior.
|
The failing tests are the flaky attach test-- I'm writing a PR to make it non-flaky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement query cancellation for DuckDB/MotherDuck using conn.interrupt() duckdb/duckdb#7895