Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set duckdb_api #1740

Closed
wants to merge 1 commit into from
Closed

Set duckdb_api #1740

wants to merge 1 commit into from

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented May 21, 2024

By default, "cpp" is the fallthrough option for duckdb_api. This PR sets it to wasm instead.

Before the change:

┌─────────────────────────────┐
│ user_agent                  │
╞═════════════════════════════╡
│ duckdb/v0.10.2(wasm_eh) cpp │
└─────────────────────────────┘

After the change:

duckdb> pragma user_agent;
┌──────────────────────────────┐
│ user_agent                   │
╞══════════════════════════════╡
│ duckdb/v0.10.2(wasm_eh) wasm │
└──────────────────────────────┘

@carlopi
Copy link
Collaborator

carlopi commented May 21, 2024

Thanks!

@elefeint elefeint changed the title et duckdb_api Set duckdb_api May 21, 2024
@elefeint
Copy link
Contributor Author

@carlopi sorry, I have no idea how I could have possibly triggered this, but the previous builds seem to have been successful. Do you have ideas?

2024-05-21T16:49:48.9547308Z In file included from /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/src/arrow/ipc/feather.cc:30:
2024-05-21T16:49:48.9551757Z /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/thirdparty/flatbuffers/include/flatbuffers/flatbuffers.h:1884:12: error: overload resolution selected deleted operator '='
2024-05-21T16:49:48.9553880Z  1884 |       buf_ = other.buf_;
2024-05-21T16:49:48.9554623Z       |       ~~~~ ^ ~~~~~~~~~~

@carlopi
Copy link
Collaborator

carlopi commented May 22, 2024

@carlopi sorry, I have no idea how I could have possibly triggered this, but the previous builds seem to have been successful. Do you have ideas?

2024-05-21T16:49:48.9547308Z In file included from /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/src/arrow/ipc/feather.cc:30:
2024-05-21T16:49:48.9551757Z /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/thirdparty/flatbuffers/include/flatbuffers/flatbuffers.h:1884:12: error: overload resolution selected deleted operator '='
2024-05-21T16:49:48.9553880Z  1884 |       buf_ = other.buf_;
2024-05-21T16:49:48.9554623Z       |       ~~~~ ^ ~~~~~~~~~~

I think I do, it has to do likely with a bump in emscripten, but I think I have the fix, will send it soon.

@carlopi
Copy link
Collaborator

carlopi commented May 29, 2024

I think the problem was connected to bumping arrow. Done and merged the PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants