Join order optimizer asan bug Follow up #11794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to remove lots of unused code
…t rather the address of the DPJoinNode in the dp table
…ctor iterator position
Tmonster
changed the title
Tmonster
requested review from
Mytherin and
lnkuiper
and removed request for
Mytherin
lnkuiper
suggested changes
Apr 24, 2024
| //! Tries to emit a potential join candidate pair. Returns false if too many pairs have already been emitted, | ||
| //! cancelling the dynamic programming step. | ||
| bool TryEmitPair(JoinRelationSet &left, JoinRelationSet &right, const vector<reference<NeighborInfo>> &info); | ||
|
|
||
| unique_ptr<JoinNode> CreateJoinNodeFromDPJoinNode(DPJoinNode dp_node); | ||
| // unique_ptr<JoinNode> CreateJoinNodeFromDPJoinNode(DPJoinNode dp_node); |
There was a problem hiding this comment.
Should this comment be removed?
| return res; | ||
| } | ||
| const reference_map_t<JoinRelationSet, unique_ptr<DPJoinNode>> &PlanEnumerator::GetPlans() const { | ||
| // optional_ptr<reference_map_t<JoinRelationSet, unique_ptr<DPJoinNode>>> res = &plans; |
There was a problem hiding this comment.
Should this comment be removed?
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 5, 2024
Merge pull request duckdb/duckdb#11794 from Tmonster/join_order_optimizer_asan_bug_and_refactor Merge pull request duckdb/duckdb#11863 from Tishj/synchronize_test_requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11719
This PR removes the JoinNode class completely. In addition, it removes a lot of other dead code that should have been removed a while ago. This solution passes a const reference to the dynamic programming table of plans to the query_graph_manager so that plan reconstruction can directly reference the dynamic programming table. The reconstruction code can then lookup the left and right JoinRelationSets by looking into the DP table.