Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yyjson bump version to 2020 #12072

Merged
merged 8 commits into from
May 17, 2024
Merged

yyjson bump version to 2020 #12072

merged 8 commits into from
May 17, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented May 15, 2024

2 PR landed at the same time:

This PR bumps yyjson version in duckdb to the same commit as it was done in duckdb/duckdb_iceberg#50

@carlopi carlopi requested review from lnkuiper and Maxxen May 15, 2024 14:56
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 15, 2024 15:06
@carlopi carlopi marked this pull request as ready for review May 15, 2024 15:07
Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@carlopi
Copy link
Contributor Author

carlopi commented May 15, 2024

Not mergeable in the current form, there is a:

D SELECT json_structure('{"duck":"goose"}'->'duck');
INTERNAL Error: Unexpected yyjson tag in ValTypeToLogicalTypeId
This error signals an assertion failure within DuckDB. This usually occurs due to unexpected conditions or errors in the program's logic.
For more information, see https://duckdb.org/docs/dev/internal_errors

raised, haven't looked (yet) at what's going on.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 15, 2024 20:13
@carlopi carlopi marked this pull request as ready for review May 15, 2024 20:13
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 15, 2024 22:25
@carlopi carlopi marked this pull request as ready for review May 15, 2024 22:34
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 16, 2024 03:42
@carlopi carlopi marked this pull request as ready for review May 16, 2024 03:42
@carlopi
Copy link
Contributor Author

carlopi commented May 16, 2024

This might require another look from @lnkuiper, given due to bumping the version the implementation of json_merge_patch changed, and we are just forwarding to it so it changed also for us

Relevant commit (that changes the tests to have them pass) is here: 6977712

Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had another look, and I think you've properly adjusted for the yyjson changes. Thanks!

@Mytherin Mytherin merged commit a303e05 into duckdb:main May 17, 2024
45 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 17, 2024
@carlopi carlopi deleted the yyjson_bump branch May 22, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants