Node.js Windows Build

.github/workflows/main.yml

@@ -1225,6 +1225,31 @@ jobs:
     - name: Node 15
       run: ./scripts/node_build.sh 15
 
+  win-nodejs:
+    name: node.js Windows
+    runs-on: windows-latest
+    needs: linux-debug
+
+    strategy:
+      matrix:
+        node: [ '10', '12', '14', '15' ]
+
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        fetch-depth: 0
+
+    - name: Setup Node
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ matrix.node }}
+
+    - name: Node Version
+      run: ./scripts/node_version.sh
+
+    - name: Node
+      run: ./scripts/node_build_win.sh
+
   linux-wasm-release:
     name: WebAssembly Release
     runs-on: ubuntu-20.04

scripts/node_build_win.sh

@@ -0,0 +1,20 @@
+#!/usr/bin/env bash
+
+set -e
+
+node --version
+npm --version
+which node
+
+cd tools/nodejs
+make clean
+./configure
+
+npm install --build-from-source
+npm test
+npx node-pre-gyp package testpackage testbinary
+
+if [[ "$GITHUB_REF" =~ ^(refs/heads/master|refs/tags/v.+)$ ]] ; then
+  npx node-pre-gyp publish
+  npx node-pre-gyp info
+fi

src/execution/operator/helper/physical_load.cpp

@@ -6,11 +6,18 @@
 #ifndef _WIN32
 #include <dlfcn.h>
 #else
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
 #include <windows.h>
 
 #define RTLD_LAZY  0
 #define RTLD_LOCAL 0
 
+#undef CreateDirectory
+#undef MoveFile
+#undef RemoveDirectory
+
 #endif
 
 namespace duckdb {

tools/nodejs/binding.gyp

@@ -3,19 +3,20 @@
         {
             "target_name": "<(module_name)",
             "sources": [
-            "src/duckdb_node.cpp",
-            "src/database.cpp",
-            "src/connection.cpp",
-            "src/statement.cpp",
-            "src/utils.cpp",
-             "src/duckdb.cpp" # comment this out to build against existing lib
+                "src/duckdb_node.cpp",
+                "src/database.cpp",
+                "src/connection.cpp",
+                "src/statement.cpp",
+                "src/utils.cpp",
+                "src/duckdb.cpp" # comment this out to build against existing lib
             ],
             "include_dirs": [
                 "<!@(node -p \"require('node-addon-api').include\")"
             ],
             'defines': [
-            'NAPI_DISABLE_CPP_EXCEPTIONS=1',
-            "NAPI_VERSION=5"],
+                'NAPI_DISABLE_CPP_EXCEPTIONS=1',
+                "NAPI_VERSION=5"
+            ],
             "cflags_cc": [
                 "-frtti",
                 "-fexceptions"
@@ -43,31 +44,43 @@
             },
             "msvs_settings": {
                 "VCCLCompilerTool": {
-                    "ExceptionHandling": 1
+                    "ExceptionHandling": 1,
+                    "AdditionalOptions": [
+                        "/bigobj"
+                    ]
                 }
             },
-# uncomment this to build against existing lib
-#             "libraries": [
-#               "/Users/hannes/source/duckdb/build/release/src/libduckdb_static.a",
-#               "/Users/hannes/source/duckdb/build/release/third_party/fmt/libfmt.a",
-#               "/Users/hannes/source/duckdb/build/release/third_party/libpg_query/libpg_query.a",
-#               "/Users/hannes/source/duckdb/build/release/third_party/utf8proc/libutf8proc.a",
-#               "/Users/hannes/source/duckdb/build/release/third_party/re2/libduckdb_re2.a"
-#
-#               ]
+            "conditions": [
+                [
+                    'OS=="win"',
+                    {
+                        "defines": [
+                            "DUCKDB_BUILD_LIBRARY"
+                        ]
+                    },
+                ],  # OS=="win"
+            ],  # conditions
+            # uncomment this to build against existing lib
+            # "libraries": [
+            #     "/Users/hannes/source/duckdb/build/release/src/libduckdb_static.a",
+            #     "/Users/hannes/source/duckdb/build/release/third_party/fmt/libfmt.a",
+            #     "/Users/hannes/source/duckdb/build/release/third_party/libpg_query/libpg_query.a",
+            #     "/Users/hannes/source/duckdb/build/release/third_party/utf8proc/libutf8proc.a",
+            #     "/Users/hannes/source/duckdb/build/release/third_party/re2/libduckdb_re2.a"
+            # ]
         },
         {
-      "target_name": "action_after_build",
-      "type": "none",
-        "dependencies": [
-          "<!(node -p \"require('node-addon-api').gyp\")"
-        ],
-      "copies": [
-          {
-            "files": [ "<(PRODUCT_DIR)/<(module_name).node" ],
-            "destination": "<(module_path)"
-          }
-      ]
-    }
+            "target_name": "action_after_build",
+            "type": "none",
+            "dependencies": [
+                "<(module_name)"
+            ],
+            "copies": [
+                {
+                    "files": [ "<(PRODUCT_DIR)/<(module_name).node" ],
+                    "destination": "<(module_path)"
+                }
+            ]
+        }
     ]
 }