[Arrow] Guarantee threads don't call get_next after stream is done. #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI job kicked off! apache/arrow@45a78c3 |
|
I'll kick off a few more jobs to make sure, but everything I've run with this duckdb branch has a clean check 🚀 🚀 🚀 ! |
|
Is this a workaround you feel comfortable including in a release? The root of the problem is probably somewhere in the scanner; however, the error message doesn't give us much to go on and nobody can replicate the error anyway. |
|
Im fine with that. @Mytherin any thoughts? |
|
That's fine by me. |
Mytherin
approved these changes
Sep 16, 2022
nealrichardson
pushed a commit
to apache/arrow
that referenced
this pull request
Sep 16, 2022
#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check. Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
zagto
pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
…e#14149) apache#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check. Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
fatemehp
pushed a commit
to fatemehp/arrow
that referenced
this pull request
Oct 17, 2022
…e#14149) apache#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check. Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paleolimbot can you try the Arrow CI on this PR?
Potentially fixes: #4656