[RLE] Emit constant vectors when possible #8250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jul 17, 2023
Mytherin
reviewed
Jul 17, 2023
|
Thanks! LGTM |
Mytherin
added a commit
that referenced
this pull request
Jul 28, 2023
[RLE] Fix problem created by #8250
Tishj
added a commit
to Tishj/duckdb
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a FIXME in the code
With run length encoding, we might have runs that are as big or bigger than a vector, which means the Vector could be populated with just a single value
STANDARD_VECTOR_SIZEtimes, so instead we just emit a ConstantVector in this case.