[Dev] Only emit ConstantVectors when scan_vector
is invoked
#8916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #8869 this makes revisions to #8250
The RLE scan code previously made its own calculation of whether constant vectors could be emitted, but it seems this is not given enough context to determine this.
So now we only emit constant vectors when the
scan_vector
callback is invoked, as opposed toscan_partial