Close s3 filehandle on destruction #9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM |
1 task
|
@samansmink , is it possible that there are any non closed |
|
@brianwyka That would be possible, but i don't see how that would cause issues: the problem here was that on close, the filehandle would need to make an additional request to finalize the multipart upload. For reading there is no such thing, the filehandle can just be discarded and calling Close doesn't really do anything |
|
Okay thanks, was trying to see if it would help out with this issue I opened up: #9712 |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9772 from hawkfish/skiplist-rand Merge pull request duckdb/duckdb#9767 from samansmink/fix-vcpkg-patching-on-windows Merge pull request duckdb/duckdb#9757 from Tmonster/712-unicode-bugs Merge pull request duckdb/duckdb#9758 from samansmink/fix-issue-9727 Merge pull request duckdb/duckdb#9759 from samansmink/update-vcpkg-2023.10.19 Merge pull request duckdb/duckdb#9761 from samansmink/add-nightly-deploy-script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9727
S3 filehandle would not close automatically for s3 filehandles meaning that the multipart uploads would never be finished when the filehandle was not explicitly closed.