Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close s3 filehandle on destruction #9758

Merged
merged 1 commit into from Nov 22, 2023
Merged

Close s3 filehandle on destruction #9758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions extension/httpfs/include/s3fs.hpp
View file
Open in desktop
Expand Up @@ -112,6 +112,8 @@ class S3FileHandle : public HTTPFileHandle {
throw NotImplementedException("Cannot open an HTTP file for appending");
}
}
~S3FileHandle() override;

S3AuthParams auth_params;
const S3ConfigParams config_params;

Expand Down
4 changes: 4 additions & 0 deletions extension/httpfs/s3fs.cpp
View file
Open in desktop
Expand Up @@ -231,6 +231,10 @@ S3AuthParams S3AuthParams::ReadFrom(FileOpener *opener, FileOpenerInfo &info) {
endpoint, url_style, use_ssl, s3_url_compatibility_mode};
}

S3FileHandle::~S3FileHandle() {
Close();
}

S3ConfigParams S3ConfigParams::ReadFrom(FileOpener *opener) {
uint64_t uploader_max_filesize;
uint64_t max_parts_per_file;
Expand Down