Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADS: Popup Menus #2720

Merged

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Jan 13, 2023

Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388

Description

This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state

Steps to test this PR

Smoke test Browser Popup

UI changes

Before After After
Screenshot_20230111_125401 Screenshot_20230111_125308 Screenshot_20230111_125238

@malmstein malmstein marked this pull request as ready for review January 13, 2023 15:03
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back 🎉

@malmstein malmstein merged commit 227368b into feature/david/ads_release Jan 13, 2023
@malmstein malmstein deleted the 01-13-feature/david/ads/popup_menus branch January 13, 2023 15:45
malmstein added a commit that referenced this pull request Jan 16, 2023
malmstein added a commit that referenced this pull request Jan 18, 2023
malmstein added a commit that referenced this pull request Jan 19, 2023
malmstein added a commit that referenced this pull request Jan 20, 2023
malmstein added a commit that referenced this pull request Jan 20, 2023
malmstein added a commit that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants