New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADS: Popup Menus #2720
Merged
malmstein
merged 3 commits into
feature/david/ads_release
from
01-13-feature/david/ads/popup_menus
Jan 13, 2023
Merged
ADS: Popup Menus #2720
malmstein
merged 3 commits into
feature/david/ads_release
from
01-13-feature/david/ads/popup_menus
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2023
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nalcalag
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome back 🎉
malmstein
added a commit
that referenced
this pull request
Jan 16, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
malmstein
added a commit
that referenced
this pull request
Jan 18, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
malmstein
added a commit
that referenced
this pull request
Jan 19, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
malmstein
added a commit
that referenced
this pull request
Jan 20, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
malmstein
added a commit
that referenced
this pull request
Jan 20, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
malmstein
added a commit
that referenced
this pull request
Jan 24, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388
Description
This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state
Steps to test this PR
Smoke test Browser Popup
UI changes