ADS: Release #2668
Merged
ADS: Release #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
malmstein
force-pushed
the
feature/david/ads_release
branch
from
05eb127
to
005f410
Compare
This was referenced Dec 20, 2022
aitorvs
force-pushed
the
feature/david/ads_release
branch
from
005f410
to
70b8f09
Compare
This was referenced Dec 21, 2022
Merged
malmstein
force-pushed
the
feature/david/ads_release
branch
from
70b8f09
to
2669b8e
Compare
Merged
malmstein
force-pushed
the
feature/david/ads_release
branch
from
2aacaad
to
a2c14a4
Compare
Closed
nalcalag
force-pushed
the
feature/david/ads_release
branch
from
a2c14a4
to
191273d
Compare
aitorvs
force-pushed
the
feature/david/ads_release
branch
from
191273d
to
70b8f09
Compare
nalcalag
force-pushed
the
feature/david/ads_release
branch
from
70b8f09
to
191273d
Compare
nalcalag
force-pushed
the
feature/david/ads_release
branch
from
7392b0d
to
1742009
Compare
Closed
malmstein
force-pushed
the
feature/david/ads_release
branch
from
1742009
to
88513f0
Compare
Merged
malmstein
force-pushed
the
feature/david/ads_release
branch
from
88513f0
to
38a6079
Compare
Merged
nalcalag
force-pushed
the
feature/david/ads_release
branch
from
38a6079
to
5127ff0
Compare
Merged
malmstein
force-pushed
the
feature/david/ads_release
branch
from
2f18051
to
5127ff0
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
e17a3c9
to
a41b936
Compare
Task/Issue URL: https://app.asana.com/0/72649045549333/1203568096239636 ### Description Update Onboarding screens and related: - Onboarding carrousel - FAQ page - Design Review in task
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203514942123199 ### Description PR to update the Browser Menu specs Design review in https://app.asana.com/0/1174433894299346/1203600732931519
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203514942123197 ### Description PR to update Voice Search Design review in https://app.asana.com/0/1174433894299346/1203600732931512 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203411647299665 ### Description PR to update the Remote Messaging views Design Review in https://app.asana.com/0/1174433894299346/1203593299114126 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Task/Issue URL: https://app.asana.com/0/0/1203467500325943/f **Description** Migration of share feedback screens to new components **_Design Review_** in https://app.asana.com/0/1195897901771673/1203575646431883
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203577953787622 ### Description This PR updates the Tracker screen sections of AppTP to the latest designs ### Steps to test this PR Steps in https://app.asana.com/0/1174433894299346/1203578103740008 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL:
https://app.asana.com/0/1202857801505092/1203560741717081
### Description
This PR updates the colors of destructive primary and ghost buttons
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL:
https://app.asana.com/0/1157893581871903/1203641318924982
### Description
This PR fixes. the issue in Android 8 where the dax bubble wasn't
appearing
### Steps to test this PR
_Fresh install_
- [ ] Fresh install
- [ ] Ensure Dax Bubble appears during onboarding
Task/Issue URL: https://app.asana.com/0/0/1203687084841383/f ### Description Migrate survey views to new components ### Test in Design Review Asana task: https://app.asana.com/0/1201807753394693/1203675383875628 ### UI changes | Before | After | | ------ | ----- | || ||
Task/Issue URL: https://app.asana.com/0/0/1203411647299667/f ### Description Migrate widgets to new styles ### Steps to test this PR - Install from this branch - Add widget to your home screen - Check widgets match new designs ### UI changes | Before | After | | ------ | ----- | ||
Task/Issue URL: https://app.asana.com/0/0/1203455585574665/f ### Description This PR fixes the search interstitial screen ### UI changes | Before | After | | ------ | ----- | ||
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL:
https://app.asana.com/0/1157893581871903/1203532998797240
Task/Issue URL:
https://app.asana.com/0/home/1157893581871899/1203532998797235
### Description
This PR fixes the toolbar animations as they appear with the wrong
colors.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203411129606111 ### Description Final changes before Ship Review
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | |||
Task/Issue URLs: https://app.asana.com/0/0/1203721679624008/f https://app.asana.com/0/1202857801505092/1203499549142146/f https://app.asana.com/0/0/1203769028231491/f ### Description UI changes after final design review ### Steps to test this PR Asana task: https://app.asana.com/0/0/1203721679624008/f Co-authored-by: David González <malmstein@gmail.com>
malmstein
force-pushed
the
feature/david/ads_release
branch
from
e95084f
to
ad60751
Compare
||){kind=link}
||){kind=link}
||){kind=link}
|](https://user-images.githubusercontent.com/531613/212278920-8745b185-aa86-48c1-ab15-c45038c66483.png)||){kind=link}
||](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|||){kind=link}
malmstein
added a commit
that referenced
this pull request
Jan 31, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203364994475048 ### Description This is the cumulative stacked PR with all the Design System Changes ### Steps to test this PR Tests have been done already ### UI changes See https://app.asana.com/0/1142021229838617/1203719838157685 --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1203827081084355 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203364994475048
Description
This is the cumulative stacked PR with all the Design System Changes
Steps to test this PR
Tests have been done already
UI changes
See https://app.asana.com/0/1142021229838617/1203719838157685