autofill: send current language in runtime config #808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This PR replaces #752. There's a small amount of extra context in that PR, based on my original diff ℹ️
Required:
Task/Issue URL: https://app.asana.com/0/11984721910118/1206933877192910/f
iOS PR: N/A
macOS PR: N/A
What kind of version bump will this require?: Patch. This is backwards-compatible, and the autofill codebase falls back to 'en' when it doesn't receive a language.
Optional:
Tech Design URL: N/A
CC: @amddg44 @shakyShane
Description:
The HTML autofill UI will be translated shortly, but doing so is only possible once that UI knows which language to use. Send the current locale's two-character language code as part of the privacy config (aka 'runtime config' in the autofill codebase).
This is a backwards-compatible change, since 'language' is currently an optional input to the autofill HTML pages.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template