Pixels automatic naming prefixing fixed #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1207238594885159/f
iOS PR: -
macOS PR: https://github.com/duckduckgo/macos-browser/pull/2751
CC: @ayoy @loremattei @diegoreymendez
What kind of version bump will this require?: Patch: 144.0.1
Description
This PR contains few improvements:
.
an assertionError is fired (in Debug)NonStandardEvent
for those legacy Pixels non following the new PixelKit naming conventions, these kinds of pixels will maintain the name without automatic alterations.Internal references:
Software Engineering Expectations
Technical Design Template