Skip to content
This repository has been archived by the owner on Nov 19, 2021. It is now read-only.

Updated layout for stats. Added ability to get custom date range. #842

Merged
merged 5 commits into from
Aug 11, 2015

Conversation

kablamo
Copy link
Member

@kablamo kablamo commented Jul 28, 2015

The main goal here is to add the ability to specify a custom date range when looking at community stats.

I got carried away though and changed the look for the stats.

@jbarrett
Copy link
Contributor

I think we've resolved (or pushed out) any schema conflicts so 👍 if this works, it works :)

(we probably need to talk on that - user github link should probably be a very minimal table with link to github stats tables at some stage)

Assigning to @jagtalon to review styles.

@jagtalon
Copy link
Member

@kablamo @jbarrett hey thanks will check it soon!

@kablamo
Copy link
Member Author

kablamo commented Jul 29, 2015

@jbarrett makes sense to me. Thanks!
@jagtalon i think this page is still ugly. but i think its good enough. its not user facing. but yeah any suggestions for better code or better anything are welcome. i know its a bit sloppy.

@jagtalon
Copy link
Member

jagtalon commented Aug 3, 2015

Looks good to me although I'd like it namespaced just to be sure:

#stats_github {
    .number {
        ...
    }
}

And remove the @import since it's redundant. Take it away, @jbarrett

@jagtalon jagtalon assigned jbarrett and unassigned jagtalon Aug 3, 2015
@kablamo
Copy link
Member Author

kablamo commented Aug 4, 2015

ok I did those things @jagtalon asked of me. Thanks for the feedback! Now I'm just waiting on Zac to approve this thing. Once thats done, I'm happy to merge.

@kablamo
Copy link
Member Author

kablamo commented Aug 5, 2015

@jbarrett if you are are doing a release, I'm happy to see this pr go in. Feel free to merge.

jbarrett added a commit that referenced this pull request Aug 11, 2015
Updated layout for stats.  Added ability to get custom date range.
@jbarrett jbarrett merged commit 2896817 into dev-community Aug 11, 2015
@jbarrett jbarrett deleted the eric/github-stats-history branch August 11, 2015 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants