Ema/perf followups #386
Merged
Ema/perf followups #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
GioSensation
commented
Sep 29, 2023
| @@ -279,30 +279,27 @@ test.describe('macos', () => { | |||
| }) | |||
| test.describe('matching performance', () => { | |||
| test('real-world form', async ({page}) => { | |||
| await forwardConsoleMessages(page) | |||
There was a problem hiding this comment.
I've removed the console forwarding from these tests so we can more easily read the performance results of the test itself without digging through lots of noise.
GioSensation
commented
Sep 29, 2023
GioSensation
commented
Sep 29, 2023
| @@ -1,4 +1,4 @@ | |||
| import {buttonMatchesFormType, getTextShallow} from '../autofill-utils.js' | |||
| import {buttonMatchesFormType, getTextShallow, safeRegexTest} from '../autofill-utils.js' | |||
There was a problem hiding this comment.
I've substituted all RegExp.test instances with a wrapper that checks for string length first. Find it down below. Should probably consider an ESLint rule.
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
shakyShane
approved these changes
Oct 2, 2023
This was referenced Oct 10, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Oct 11, 2023
Task/Issue URL: https://app.asana.com/0/1205691418983700/1205691418983700 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.2 ## Description Updates Autofill to version [8.4.2](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.2). ### Autofill 8.4.2 release notes ## What's Changed * Ema/perf followups by @GioSensation in duckduckgo/duckduckgo-autofill#386 * Fix handler regression by @GioSensation in duckduckgo/duckduckgo-autofill#392 * Bump markdown-it from 13.0.1 to 13.0.2 by @dependabot in duckduckgo/duckduckgo-autofill#388 * Revert mutation observer for forms by @GioSensation in duckduckgo/duckduckgo-autofill#396 **Full Changelog**: duckduckgo/duckduckgo-autofill@8.4.1...8.4.2 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <GioSensation@users.noreply.github.com>
joshliebe
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Nov 7, 2023
Task/Issue URL: https://app.asana.com/0/1205691418983700/1205691418983700 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.2 ## Description Updates Autofill to version [8.4.2](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.2). ### Autofill 8.4.2 release notes ## What's Changed * Ema/perf followups by @GioSensation in duckduckgo/duckduckgo-autofill#386 * Fix handler regression by @GioSensation in duckduckgo/duckduckgo-autofill#392 * Bump markdown-it from 13.0.1 to 13.0.2 by @dependabot in duckduckgo/duckduckgo-autofill#388 * Revert mutation observer for forms by @GioSensation in duckduckgo/duckduckgo-autofill#396 **Full Changelog**: duckduckgo/duckduckgo-autofill@8.4.1...8.4.2 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <GioSensation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/0/1205589679117410/f
Description
Follow up for the previous PR. This abstracts
RegExp.testto a wrapper that checks for string length before executing. This is both to avoid performance spikes and for accuracy (avoiding noise). My new law of software engineering: given a long enough text, your regex will always match.For more context, on certain specific pages we were running multiple successive regex checks on humongous strings, like 60+k characters. Chrome and Firefox handled that decently, but webkit 17 (macOS Sonoma) spun out of control and basically the whole tab hanged.
Steps to test
Tests added. If you remove the safeguards and add back the selector for
titlein class and id, the test times out on Webkit 17.