switch to true|false for protectionsState param (#2326)

Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
duckduckgo · Nov 10, 2023 · 0529970 · 0529970
1 parent 5881677
commit 0529970
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/shared/js/background/broken-site-report.js b/shared/js/background/broken-site-report.js
@@ -200,7 +200,7 @@ export async function breakageReportForTab ({
         ctlYouTube,
         ctlFacebookPlaceholderShown,
         ctlFacebookLogin,
-        protectionsState: tab.site.isFeatureEnabled('contentBlocking') ? '1' : '0'
+        protectionsState: tab.site.isFeatureEnabled('contentBlocking')
     })
 
     for (const [key, value] of Object.entries(requestCategories)) {

diff --git a/unit-test/background/reference-tests/broken-site-reporting-tests.js b/unit-test/background/reference-tests/broken-site-reporting-tests.js
@@ -156,7 +156,7 @@ describe('Broken Site Reporting tests / protections state', () => {
         spyOnProperty(tab.site, 'enabledFeatures').and.returnValue(['contentBlocking'])
 
         const params = await submit(tab)
-        expect(params.get('protectionsState')).toEqual('1')
+        expect(params.get('protectionsState')).toEqual('true')
     })
     it('sends 1 when site is denylisted', async () => {
         const tab = new Tab({ url: 'https://example.com' })
@@ -165,15 +165,15 @@ describe('Broken Site Reporting tests / protections state', () => {
         spyOnProperty(tab.site, 'denylisted').and.returnValue(true)
 
         const params = await submit(tab)
-        expect(params.get('protectionsState')).toEqual('1')
+        expect(params.get('protectionsState')).toEqual('true')
     })
     it('sends 0 when site is allowlisted', async () => {
         const tab = new Tab({ url: 'https://example.com' })
         spyOnProperty(tab.site, 'enabledFeatures').and.returnValue(['contentBlocking'])
         spyOnProperty(tab.site, 'allowlisted').and.returnValue(true)
 
         const params = await submit(tab)
-        expect(params.get('protectionsState')).toEqual('0')
+        expect(params.get('protectionsState')).toEqual('false')
     })
     it('sends 0 when contentBlocking is not enabled', async () => {
         const tab = new Tab({ url: 'https://example.com' })
@@ -182,7 +182,7 @@ describe('Broken Site Reporting tests / protections state', () => {
         spyOnProperty(tab.site, 'enabledFeatures').and.returnValue([])
 
         const params = await submit(tab)
-        expect(params.get('protectionsState')).toEqual('0')
+        expect(params.get('protectionsState')).toEqual('false')
     })
     it('sends 0 when domain is in unprotectedTemporary', async () => {
         const tab = new Tab({ url: 'https://example.com' })
@@ -191,6 +191,6 @@ describe('Broken Site Reporting tests / protections state', () => {
         spyOnProperty(tab.site, 'isBroken').and.returnValue(true)
 
         const params = await submit(tab)
-        expect(params.get('protectionsState')).toEqual('0')
+        expect(params.get('protectionsState')).toEqual('false')
     })
 })