Correct post install pathname (#1711)

* Test for correct post install pathname * Fix post-install ATB parameter
duckduckgo · Feb 8, 2023 · c2a16d8 · c2a16d8
1 parent b65ffe4
commit c2a16d8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/integration-test/background/atb.js b/integration-test/background/atb.js
@@ -31,11 +31,11 @@ describe('install workflow', () => {
             // if it never does, jasmine timeout will kick in
             while (!postInstallOpened) {
                 const urls = await Promise.all(browser.targets().map(target => target.url()))
-                postInstallOpened = urls.some(url => url.includes('duckduckgo.com/extension-success'))
+                postInstallOpened = urls.find(url => url.includes('duckduckgo.com/extension-success'))
                 await backgroundWait.forTimeout(bgPage, 100)
             }
-
             expect(postInstallOpened).toBeTruthy()
+            expect(new URL(postInstallOpened).pathname).toBe('/extension-success')
         })
     })
 

diff --git a/shared/js/background/atb.es6.js b/shared/js/background/atb.es6.js
@@ -195,7 +195,7 @@ const ATB = (() => {
                 settings.updateSetting('hasSeenPostInstall', true)
                 let postInstallURL = 'https://duckduckgo.com/extension-success'
                 const atb = settings.getSetting('atb')
-                postInstallURL += atb ? `&atb=${atb}` : ''
+                postInstallURL += atb ? `?atb=${atb}` : ''
                 browser.tabs.create({
                     url: postInstallURL
                 })