Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking up on Konva (Canvas) Applications #560

Closed
abrahamfathman opened this issue Mar 4, 2021 · 1 comment · Fixed by #561
Closed

Locking up on Konva (Canvas) Applications #560

abrahamfathman opened this issue Mar 4, 2021 · 1 comment · Fixed by #561

Comments

@abrahamfathman
Copy link

Description

Chrome browser tab becomes unresponsive. A dialog saying 'Page Unresponsive' is shown with the choice to 'Exit Page' or 'Wait'

Steps to Reproduce

  1. Go to a site that is using Konva - like their demo here: https://konvajs.org/docs/sandbox/Free_Drawing.html
  2. Try to scroll up and down on the web page

Expected behavior:
The web page will be responsive and you can see the HTML Canvas elements functioning.

Actual behavior:
Within 10 seconds, the browser page becomes unresponsive.

Versions

  • Extension: 2021.3.2
  • Browser: Chrome: 88.0.4324.192 (Official Build) (x86_64)
  • OS: Mac

Additional Information

This is repeatable every time.
This started with version 2021.3.2.

@jonathanKingston
Copy link
Collaborator

Thanks for the report!

this.hitCanvas.context.getImageData(Math.round(pos.x * ratio), Math.round(pos.y * ratio), 1, 1).data

I'm seeing this as the source of the troubles, I think it's because the subset of the canvas data we are modifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants