Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getImageData massive slowdown in 2021.3.8 #574

Closed
FizzerWL opened this issue Mar 19, 2021 · 7 comments
Closed

getImageData massive slowdown in 2021.3.8 #574

FizzerWL opened this issue Mar 19, 2021 · 7 comments

Comments

@FizzerWL
Copy link

Hello,

Ever since the March 11th 2021 release of version 2021.3.8, I find that calling "getImageData" on a canvas is massively slower than previous versions. Something like 150 milliseconds to return a single pixel of the canvas.

This is causing a big problem for me. I'm the developer of a website that uses this function, and many of my users are complaining that my site runs slowly. I figured out that every user complaining has the DuckDuckGo extension installed. For now I'm advising them to uninstall the extension, but it'd be preferable if this problem could be resolved.

You can reproduce the problem at this url: https://www.warzone.com/SinglePlayer?Level=50 . Try zooming in then dragging around the map. You'll find it's very fast faster with the DDG extension disabled, but when enabling it it's massively slow.

@dharb
Copy link
Contributor

dharb commented Mar 19, 2021

Hi @FizzerWL, thanks for the report! We recently shipped some canvas anti-fingerprinting functionality that must be causing this, sorry about the trouble. I'm going to disable it on your website for the time being while we sort out a fix for the issue.

@dharb
Copy link
Contributor

dharb commented Mar 19, 2021

@FizzerWL we just disabled the canvas fingerprint protections on your site for the time being while we address the root issue. This change should be rolling out to all users in the next hour or so. If you continue to receive reports about this after this change is live, will you please let us know? Thanks!

@FizzerWL
Copy link
Author

Yes, from my testing your temporary solution was successful. Thank you so much for the prompt response!

@seeba8
Copy link

seeba8 commented Mar 20, 2021

I have a similar problem on skribbl.io, I think. I recorded a performance profile in firefox: https://share.firefox.dev/3f2rEdQ
When I add it to the list of unprotected sites, I can draw just like normal. If I don't, it lags out completely.

Maybe that helps pinpointing the issue.

@ChadKeating
Copy link

@dharb @jonathanKingston Please could you make this exemption for my site, my tokenstamp app is unusable with privacy essentials installed, dragging an image on to the page can make it hang forever: https://rolladvantage.com/tokenstamp/

@Yazir
Copy link

Yazir commented Apr 16, 2021

Any substantial update on this issue, at least an ETA? My I get reports of text on my phaser app (automeme.yazaa.zone) being misaligned.

@jonathanKingston
Copy link
Collaborator

Hey @Yazir the original issue here was finished and should be live solving the majority of the performance issues at hand here. I think it makes sense to move the phaser sizing problem to a new issue. It's the same code causing the issue but unrelated in how we would fix it. I raised #610 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants