Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2022.4.26 #1150

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Release 2022.4.26 #1150

merged 3 commits into from
Apr 26, 2022

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Apr 26, 2022

Reviewer: @sammacbeth or @GioSensation

Description:

https://app.asana.com/0/312629933896096/1202181759555718/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston requested review from sammacbeth and GioSensation and removed request for sammacbeth April 26, 2022 08:57
@jonathanKingston jonathanKingston merged commit 7ec7b1a into develop Apr 26, 2022
@jonathanKingston jonathanKingston deleted the release-2022.4.26 branch April 26, 2022 21:09
@@ -36,7 +36,7 @@
"@babel/polyfill": "^7.10.4",
"@babel/preset-env": "^7.16.11",
"@fingerprintjs/fingerprintjs": "^3.3.3",
"asana": "^0.18.6",
"asana": "github:Asana/node-asana",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this pull latest main branch? Could we pin this to a commit or tag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This should pull the latest tags on GH.
  • We had Asana issues which turned out to being unrelated to this but it is kinda weird they're not releasing to npm.
  • Switching to this should have dependabot update for us as before and we pin in the package-lock file.
    • If there's concerns I think you can append @versionstring to the end here also.

Eitherway let me file an issue for fixing a deprecation with asana :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants