Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for email protection logout #1162

Merged
merged 3 commits into from
May 24, 2022

Conversation

alistairjcbrown
Copy link
Member

@alistairjcbrown alistairjcbrown commented May 9, 2022

Reviewer: @jonathanKingston

Description:

Task: https://app.asana.com/0/0/1202050175851755/f

Allows the extension to communicate supported capabilities to the Email Protection web app, as well as support the web app requesting sign out.

Steps to test this PR:

  1. Checkout this branch and run npm run release-chrome
  2. Open Chrome, and load the extension build
  3. Go to https://duckduckgo.com/email/settings and log in
    • Confirm that the extension has email autofill enabled by going to the extension settings
  4. A "Sign Out" button should be visible at the bottom of the Email Protection settings page
  5. Click the "Sign Out" button -- you should be logged out of the settings page
    • Confirm that the extension has email autofill disabled by going to the extension settings

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston
Copy link
Collaborator

LGTM I'll test tomorrow. Thanks

@alistairjcbrown
Copy link
Member Author

@jonathanKingston Updated to latest autofill. Any changes required for this PR?

Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope all good, thanks for version bumping here :)

@jonathanKingston jonathanKingston merged commit b3e9484 into develop May 24, 2022
@jonathanKingston jonathanKingston deleted the abrown/email-protection-logout branch August 17, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants