Improve reliability of Click to Load integration tests #1182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While they run reliably locally, some of the Click to Load integration
tests are flaking on CI. These improvements aim to help reduce those
flakes:
than as a failure. There's not much we can do to get around network
failure.
to play it.
extension configuration to load. If extension configuration fails
to load, throw a clear exception to explain that.
that Puppeteer fails to click.
attempt to be unloaded, even when the test configuration failed to
load.
message.
out but continue with the tests.
and log an appropriate message. This happens when the network is
too slow and the video fails to load within 30 seconds.
Reviewer: @jonathanKingston
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: