Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler cookie policy #1204

Merged
merged 1 commit into from
May 30, 2022
Merged

Simpler cookie policy #1204

merged 1 commit into from
May 30, 2022

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented May 27, 2022 •
edited

Description:

https://app.asana.com/0/0/1202348774384668/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston force-pushed the jkt/simpler-cookie-policy branch 6 times, most recently from f453668 to a0e306e Compare May 27, 2022 19:48
@jonathanKingston jonathanKingston marked this pull request as ready for review May 27, 2022 23:02
@jonathanKingston jonathanKingston force-pushed the jkt/simpler-cookie-policy branch 6 times, most recently from bd0a03a to a9cc94f Compare May 27, 2022 23:41
SlayterDev
SlayterDev reviewed May 28, 2022
View reviewed changes
shared/data/etags.json Outdated Show resolved Hide resolved
@jonathanKingston jonathanKingston force-pushed the jkt/simpler-cookie-policy branch 2 times, most recently from 57110f4 to ca226d8 Compare May 28, 2022 13:05
SlayterDev
SlayterDev approved these changes May 28, 2022
View reviewed changes
Copy link
Contributor

@SlayterDev SlayterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it 🚀

@jonathanKingston jonathanKingston merged commit 11bb055 into duckduckgo:develop May 30, 2022
@jonathanKingston jonathanKingston deleted the jkt/simpler-cookie-policy branch May 30, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlayterDev SlayterDev SlayterDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanKingston @SlayterDev