Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for new PD #1271

Merged
merged 22 commits into from
Nov 22, 2022
Merged

added support for new PD #1271

merged 22 commits into from
Nov 22, 2022

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jul 5, 2022

Reviewer: @jonathanKingston

https://app.asana.com/0/0/1203280236620710/f

Description:

Added support for new Privacy Dashboard

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@shakyShane shakyShane marked this pull request as ready for review November 1, 2022 19:52
@shakyShane
Copy link
Contributor Author

shakyShane commented Nov 1, 2022

@jonathanKingston 2 quick things:

1 - there a bug with searching at the moment (the field gets wiped when new data arrives) - it'll be fixed soon and doesn't affect any changes here
2 - there's a failing integration test for CTL (I think), is this known to be flaky?

@jonathanKingston
Copy link
Collaborator

Overall looks great; I've not tested it yet as you mentioned the search is still broken and the tests are failing still.
The CTP test should disable itself, I reran and was fine.

@shakyShane shakyShane force-pushed the shane/pd branch 2 times, most recently from f59dfb7 to fec7818 Compare November 7, 2022 19:51
@shakyShane shakyShane merged commit f813850 into develop Nov 22, 2022
@jonathanKingston
Copy link
Collaborator

Very triggering gif of snape and dumbledoor with the caption 'party hard'

@shakyShane shakyShane deleted the shane/pd branch December 1, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants